[SSDK-542] Update maki icons to SVG #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e - SSDK-542 - Generate latest assets with some changes and some additions - All other file changes are binary noise
- Remove development output - Remove commends - Fix contents.json
…assetName field - SSDK-542
…542-update-maki-icons Conflicts: CHANGELOG.md
azarovalex
previously approved these changes
Feb 7, 2024
I might have to set up a virtual machine with an older macOS to run an older Xcode 😅 😓 |
I looked into both options and found that A) I can't validate on iOS 12 unless we find an old iOS device or Mac and B) SVG support should be acceptable and backwards compatible, just that iOS 12 devices will use PNGs converted by Xcode. [https://sarunw.com/posts/svg-image-assets-supported-in-xcode12/, https://www.willowtreeapps.com/craft/what-svg-support-means-for-your-ios-app-graphics] |
azarovalex
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SSDK-542
Checklist
CHANGELOGScreenshots